Repository navigation
Conversation
Cargo.toml's repository field and the README CI badge (image and link) pointed at the personal fork iglocska/RustMISP instead of the org repo MISP/RustMISP. On the org repo this makes the CI badge resolve against the fork's workflow runs, so it can show green while org CI is red. Confirmed org name against this worktree's own `origin` remote (https://github.com/MISP/RustMISP). The license and rust badges already pointed at a relative LICENSE file and rust-lang.org respectively (not iglocska), so they needed no change. The PyMISP parity badge values and their scripts/check_pymisp_parity.py link targets are untouched, per instructions (CI auto-commits those values). grep -rn iglocska . confirmed only Cargo.toml:8 and README.md:3 referenced the fork before this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JoSButbVaWEtGMXwTx73BZ
elhoim
marked this pull request as draft
September 3, 2026 05:04
Contributor
Author
|
[pr-sweep] implemented upstream in ee2f7a5 - closing. Upstream ee2f7a5 (chg: [package] Point the repository and the CI badge at MISP/RustMISP) makes the same two edits: Cargo.toml's repository field and the README CI badge now point at MISP/RustMISP. Verified mechanically: cherry-picking this PR's single commit onto current main is empty, and the result is identical to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLUF — Package metadata and the CI badge point at a personal fork instead of the org repository.
Cargo.toml'srepositoryfield and theREADME.mdCI badge (image src and link href) referencediglocska/RustMISPrather thanMISP/RustMISP, so on the org repo the badge resolves against the fork's workflow runs and can read green while org CI is red.https://github.com/MISP/RustMISP; a grep confirmed these were the only two references. The license and Rust badges already used non-org targets and were left as-is.test_event_crud_lifecycleraced the publish worker), fixed in PR fix: [ci] Run integration tests on ubuntu-24.04 to match php8.3 #53 and unrelated to this PR.Finding
repository field and README badges point at iglocska/RustMISP, not MISP/RustMISP
On the org repo the CI badge resolves against the personal fork's workflow runs, so it can show green while org CI is red.
Change
Cargo.toml's
repositoryfield and the README CI badge (both image src and link href) pointed at the personal fork iglocska/RustMISP instead of the org repo MISP/RustMISP. Changed both to https://github.com/MISP/RustMISP so the CI badge resolves against the org repo's own workflow runs rather than the fork's. Confirmed the target org name against this worktree's ownorigingit remote (https://github.com/MISP/RustMISP), and confirmed via grep that no other file referenced iglocska.Upstream evidence
N/A — this is a repository-metadata/docs fix (Cargo.toml field + README badge URLs), not a wire-protocol or MISP-API behavior, so there is no MISP controller or PyMISP method to cite. Verified instead via
git remote -vin the worktree (origin = https://github.com/MISP/RustMISP) andgrep -rn iglocska .which found only Cargo.toml:8 and README.md:3 before the fix, and nothing after.Verified against MISP core
843b6744and PyMISPe7debb4f.Tests
No runnable test: this is a docs/CI-only change, or the affected test requires a live MISP instance.
Note on the original finding
Slightly overstated. The finding said "CI/license/rust badge URLs" all pointed at iglocska, but only the CI badge (both its badge.svg image URL and its link target) and the Cargo.toml repository field actually did. The license badge already links to a relative
LICENSEfile (no org reference) and the Rust badge already links to rust-lang.org (no org reference) — neither needed changing. Per instructions the two PyMISP parity badge values and their scripts/check_pymisp_parity.py link targets were left untouched since those targets were already correct.Caveats
Docs/metadata-only change (no Rust code touched), so
cargo fmtwas a no-op and no test was added or modified — there is no testable Rust code path for a repository-URL/badge string. Verified the correct org name (MISP) directly from this worktree's ownoriginremote rather than relying solely on the finding text.Verified locally:
cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings,cargo test --all-features --lib,--test integration_tests --no-run, andcargo check --examples, each in an isolated target directory.🤖 Generated with Claude Code