Repository navigation
fix(subscriptions): describe copy action in feed link tooltips - #2049
Merged
JohnVillalovos merged 1 commit intoNov 22, 2026
Merged
Conversation
The Atom and iCalendar links on the schedule and the schedule admin page used "URL copied to clipboard" as their hover title, although nothing is copied until the link is clicked. On the public resource page the Atom link reused "Subscribe to this Calendar", which describes the iCalendar link. Add a CopyUrlToClipboard string and use it as the title of all links that copy a feed URL. The toast keeps UrlCopiedToClipboard. Closes: LibreBooking#2034 Assisted-by: Claude:claude-opus-5-5
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed tooltip updates and translations consistently distinguish the pre-copy action from the post-click confirmation across the listed feed links, with no active review issues identified.
No open issues 🎉
What changed in this PR
Corrects subscription-feed link tooltips so they describe the copy action before a URL is copied, while preserving the existing post-click confirmation message.
Changes:
- Adds the
CopyUrlToClipboardtranslation key. - Applies the copy-action tooltip to Atom and iCalendar links on schedule, admin schedule, and public resource pages.
- Adds translations for English, German, Spanish, French, and Italian.
| File | Description |
|---|---|
| tpl/Schedule/schedule.tpl | Updates schedule Atom and iCalendar links to use the copy-action tooltip. |
| tpl/Admin/Schedules/manage_schedules.tpl | Updates administered schedule feed links to use the copy-action tooltip. |
| tpl/Admin/Resources/manage_resources_public.tpl | Corrects the tooltips for public resource iCalendar and Atom links. |
| lang/it_it.php | Adds the Italian translation for the copy-action tooltip. |
| lang/fr_fr.php | Adds the French translation for the copy-action tooltip. |
| lang/es.php | Adds the Spanish translation for the copy-action tooltip. |
| lang/en_us.php | Adds the English copy-action translation key. |
| lang/de_de.php | Adds the German translation for the copy-action tooltip. |
Review effort: Lite
JohnVillalovos
approved these changes
Nov 22, 2026
JohnVillalovos
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thanks @lucs7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Atom and iCalendar links on the schedule page and on
Application Management → Schedules used "URL copied to clipboard"
as their hover
title, although nothing is copied until the link isclicked. On the public resource page the Atom link reused "Subscribe to
this Calendar", which describes the iCalendar link next to it.
This PR adds a
CopyUrlToClipboardstring ("Copy URL to clipboard") anduses it as the
titleof every link that copies a feed URL:tpl/Schedule/schedule.tpltpl/Admin/Schedules/manage_schedules.tpltpl/Admin/Resources/manage_resources_public.tplThe toast in
globalfooter.tplstill usesUrlCopiedToClipboard, sothe "copied" message only shows up after a click.
Translations are added for en_us, de_de, es, fr_fr and it_it. Other
languages fall back to the English string.
Related issues
Closes: #2034
🤖 Generated with Claude Code