Skip to content

fix(subscriptions): describe copy action in feed link tooltips - #2049

Merged
JohnVillalovos merged 1 commit into
LibreBooking:mainfrom
lucs7:fix/2034-copy-url-tooltip
Nov 22, 2026
Merged

JohnVillalovos merged 1 commit into
LibreBooking:mainfrom
lucs7:fix/2034-copy-url-tooltip

Conversation

@lucs7

@lucs7 lucs7 commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

Description

The Atom and iCalendar links on the schedule page and on
Application Management → Schedules used "URL copied to clipboard"
as their hover title, although nothing is copied until the link is
clicked. On the public resource page the Atom link reused "Subscribe to
this Calendar", which describes the iCalendar link next to it.

This PR adds a CopyUrlToClipboard string ("Copy URL to clipboard") and
uses it as the title of every link that copies a feed URL:

  • tpl/Schedule/schedule.tpl
  • tpl/Admin/Schedules/manage_schedules.tpl
  • tpl/Admin/Resources/manage_resources_public.tpl

The toast in globalfooter.tpl still uses UrlCopiedToClipboard, so
the "copied" message only shows up after a click.

Translations are added for en_us, de_de, es, fr_fr and it_it. Other
languages fall back to the English string.

Related issues

Closes: #2034

🤖 Generated with Claude Code

The Atom and iCalendar links on the schedule and the schedule
admin page used "URL copied to clipboard" as their hover title,
although nothing is copied until the link is clicked. On the
public resource page the Atom link reused "Subscribe to this
Calendar", which describes the iCalendar link.

Add a CopyUrlToClipboard string and use it as the title of all
links that copy a feed URL. The toast keeps UrlCopiedToClipboard.

Closes: LibreBooking#2034
Assisted-by: Claude:claude-opus-5-5
Copilot AI lite review requested due to automatic review settings November 22, 2026 16:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed tooltip updates and translations consistently distinguish the pre-copy action from the post-click confirmation across the listed feed links, with no active review issues identified.

No open issues 🎉

What changed in this PR

Corrects subscription-feed link tooltips so they describe the copy action before a URL is copied, while preserving the existing post-click confirmation message.

Changes:

  • Adds the CopyUrlToClipboard translation key.
  • Applies the copy-action tooltip to Atom and iCalendar links on schedule, admin schedule, and public resource pages.
  • Adds translations for English, German, Spanish, French, and Italian.
File Description
tpl/​Schedule/​schedule.tpl Updates schedule Atom and iCalendar links to use the copy-action tooltip.
tpl/​Admin/​Schedules/​manage_schedules.tpl Updates administered schedule feed links to use the copy-action tooltip.
tpl/​Admin/​Resources/​manage_resources_public.tpl Corrects the tooltips for public resource iCalendar and Atom links.
lang/​it_it.php Adds the Italian translation for the copy-action tooltip.
lang/​fr_fr.php Adds the French translation for the copy-action tooltip.
lang/​es.php Adds the Spanish translation for the copy-action tooltip.
lang/​en_us.php Adds the English copy-action translation key.
lang/​de_de.php Adds the German translation for the copy-action tooltip.

Review effort: Lite

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @lucs7

@JohnVillalovos
JohnVillalovos merged commit 582715a into LibreBooking:main Nov 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Atom/iCalendar links show "URL copied to clipboard" as a hover tooltip

3 participants