Repository navigation
Restore Haussmann tabletop placement and cart review - #119
Merged
Merged
Conversation
Route catalogue clicks through the PlayCanvas reviewed support picker before falling back to floor masks. Resolve saved attachments with existing validation so tabletop items inherit the parent pose and cannot overhang or collide. Restore the unmerged cart review interaction with item, provider, quantity, price and a choose-another-spot action while keeping the current AI sidebar and price formatting. Add conservative top profiles for 15 packaged catalogue table and desk GLBs whose central rectangles are fully covered by horizontal mesh triangles. Pin each to its model hash and verify geometry and Haussmann server placement in backend acceptance tests. Track the regression under issue #118 and William’s Kanban/TODO. Local Haussmann card placement saved a desk and attached lamp; the in-app designer saved an attached keyboard and visually reviewed it. Backend 395 tests passed (5 skipped), frontend 209+25 passed, board 6 passed, and Vercel-mode build passed. Remaining risk: models without reviewed tops still cannot support objects; hosted acceptance follows merge.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
8749c766: item number, provider, quantity, known USD price, tax note, Add to cart and Choose another spot. Preserve the current AI sidebar and unknown-price handling.Why
The catalogue intercepted clicks before PlayCanvas and sampled only the floor mask, bypassing the support picker introduced by
4f57627. The review replacement in8749c766never reached main. The older broad stacking helper was deliberately removed in7d8695f; this uses the current reviewed attachment contract.Verification
place_supporteda keyboard beside the lamp at Y75, saved and visually reviewed. The microphone transcript uses the samerun(text)path; physical mic was not replayed for this change.53ba6b7: backendRan 395 tests in 12.374s / OK (skipped=5); frontend 216+26 pass; board 6 pass; Vercel-mode build 2.99s. Geometry tests compare all 15 target areas and hashes to the actual GLB triangles.Closes #118 after hosted verification.