Repository navigation
39 bug draw source video render is not executed if draw source update isnt called before - #40
Merged
HichTala merged 3 commits intoNov 9, 2026
Conversation
… and remove the shared memory initialisation in the creation of the plugin source since it's called anyway in the source render function
…dated resulting in constantly re generate the render
HichTala
deleted the
39-bug-draw_source_video_render-is-not-executed-if-draw_source_update-isnt-called-before
branch
November 9, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is following
draw_source_video_renderis not executed ifdraw_source_updateisn't called before #39it corrects the issue by adding a
resolve_sourcefunction that is called when the plugin source is created and at the start of source render function if the target source is still not referenced and reference the target source.I also took advantage of this PR to remove the not needed anymore shared memory initialisation in the plugin source creation since it's called anyway in the render function.
It also update the
context->source_widthandcontext->source_heightinside the render function so the render isn't re-created at each step.