Skip to content

Clean up dead /login and /signup redirects/checks left over from /signIn and /register rename - #366

Merged
ezraexe merged 1 commit into
mainfrom
theerth/362-fix-redirects
Oct 4, 2026
Merged

ezraexe merged 1 commit into
mainfrom
theerth/362-fix-redirects

Conversation

@Theerth1

Copy link
Copy Markdown
Contributor

Description

Resolves ticket number: #362

Explain what your code changes:
Removed three leftover references to the old /login and /signup routes (replaced by /signIn and /register), which were dead code left over from the rename. No behavior change + these paths were already unreachable since AuthenticationProvider redirects logged-out users to /signIn before any of this code runs.

  • src/app/page.tsx — removed the redirect("/login") fallback (and now-unused import)
  • src/components/NotificationHandler.tsx — removed a dead pathname === "/login" check that never matched
  • src/middleware.ts — removed /signup from publicPaths (no page exists there; /register already covers sign-up)

List the steps you took to test your code:

  1. Used grep to search for remnants of /login and /signup in src
  2. Tried to force /register from URL (redirected to /signIn as expected)
  3. Logged in in as a staff account and landed on dashboard
  4. Logged in as a partner account and landed on the partner dashboard
  5. Generated a real invite via staff account management page, pulled invite token from DB and visited /register?token= while logged out (sign up form loaded and worked correctly)
  6. Deactivated the test invite account afterward to cleanup

Checklist

  • [✅] The ticket is mentioned above
  • [✅] The changes fulfill the success criteria of the ticket
  • [✅] The changes were self-reviewed
  • [✅] A review was requested
img3 h4himg2 h4h img 1

@netlify

netlify Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hope-for-haiti ready!

Name Link
🔨 Latest commit 0fdb4d9
🔍 Latest deploy log https://app.netlify.com/projects/hope-for-haiti/deploys/6aab41ce8abc21000877693f
😎 Deploy Preview https://deploy-preview-366--hope-for-haiti.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Theerth1
Theerth1 requested a review from ezraexe September 26, 2026 16:10
@ezraexe

ezraexe commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@greptile review

@greptile-apps

greptile-apps Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

RetriggerConfidence Score: 5/5

[Medium risk] Removes dead authentication route redirects and checks.

The PR appears safe to merge; the removed checks do not serve an existing route or sign-up flow.

What we checked:

  • Signed-out visitors see a blank home page: The middleware sends signed-out visitors to /signIn, and the page wrapper also keeps them from seeing the home page.

Summary

This PR removes three checks for routes that no longer exist. The active /signIn and /register routes remain unchanged. No actionable issues were found. Owner checklist: no applicable area needs improvement; the linter was not run during this review. Score: 100/100.

Reviews (1) · Last reviewed commit: "Clean up dead /login and /signup redirec..."

@ezraexe
ezraexe merged commit f466295 into main Oct 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants