Repository navigation
Notifications Icon on Login - #334
Conversation
✅ Deploy Preview for hope-for-haiti ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Greptile SummaryThis PR hides the floating notification bell on the login/unauthenticated view by adding a Score: 95 / 100 Checklist items in good shape — no unused imports, no console.logs, hooks are called unconditionally before the early return. The only minor point is the Confidence Score: 5/5Safe to merge — changes are minimal, correct, and solve the stated ticket. Both changes are straightforward and well-scoped: the early-return guard in FloatingNotification is Rules-of-Hooks compliant and directly fixes the UI bug; the sessionStorage cleanup before signOut() is a sound defensive measure given that a full-page redirect can race the existing useEffect cleanup. No P0/P1 findings; the single P2 comment is a trivial micro-optimisation. No files require special attention. Important Files Changed
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Description
Resolves ticket number: #328
Explain what your code changes:
Removes notification icon on login page and also deletes notifications from sessionStorage on logout.
List the steps you took to test your code:
Just made sure everything worked on localhost
Checklist