Skip to content

ezra/325-negating-duplicate-offer-error #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ND68 merged 2 commits into from
Apr 11, 2026
Merged

ezra/325-negating-duplicate-offer-error #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c515172
negating out fileErrorMessage
ezraexe Apr 11, 2026
20b6655
Sign-Offs to Completed Sign-Offs
ezraexe Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/donorOffers/[donorOfferId]/finalize/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export default function FinalizeDonorOfferPage() {
onReset={resetUpload}
/>

{errors && errors.length > 0 && <ErrorDisplay errors={errors} />}
{errors && errors.length > 0 && !fileErrorMessage && <ErrorDisplay errors={errors} />}

@greptile-apps greptile-apps Bot Apr 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Same multi-error truncation issue as create/page.tsx

The same logic applies here: when the finalize API returns several row-level CSV errors, fileErrorMessage only captures the first, so suppressing ErrorDisplay with !fileErrorMessage hides all subsequent errors from the user. See the comment on create/page.tsx for the full analysis and a suggested remediation.


{preview && <PreviewTable final={true} data={previewData} />}

Expand Down
2 changes: 1 addition & 1 deletion src/app/donorOffers/create/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export default function CreateDonorOfferPage() {
onReset={resetUpload}
/>

{errors && errors.length > 0 && <ErrorDisplay errors={errors} />}
{errors && errors.length > 0 && !fileErrorMessage && <ErrorDisplay errors={errors} />}

@greptile-apps greptile-apps Bot Apr 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Multi-error responses silently truncated

When the API returns multiple validation errors (e.g. several invalid CSV rows), useFileUpload stores them all in errors[] but only puts the first message in fileErrorMessage. Because !fileErrorMessage now suppresses ErrorDisplay, errors 2-N are never shown — FileInfoDisplay only renders fileErrorMessage, which is errorMessages[0].

In useFileUpload.ts lines 85-86:

setErrors(errorMessages);        // full list
setFileErrorMessage(errorMessages[0]); // first entry only

A user uploading a CSV with multiple row-level errors would only ever see the first error and would have to fix and re-upload iteratively rather than fixing everything at once.

Consider showing ErrorDisplay when there are more errors than fileErrorMessage covers:

Suggested change
{errors && errors.length > 0 && !fileErrorMessage && <ErrorDisplay errors={errors} />}
{errors && errors.length > 0 && (!fileErrorMessage || errors.length > 1) && <ErrorDisplay errors={fileErrorMessage ? errors.slice(1) : errors} />}

Or alternatively, set fileErrorMessage to a generic summary (e.g. "File contains errors — see details below") so the detailed list is always rendered via ErrorDisplay.


{preview && <PreviewTable final={false} data={data} />}

Expand Down
2 changes: 1 addition & 1 deletion src/screens/AdminDistributionsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useRouter } from "next/navigation";
enum DistributionTab {
DISTRIBUTIONS = "Distributions",
SHIPMENTS = "Shipments",
SIGNOFFS = "Sign-offs"
SIGNOFFS = "Completed Sign-offs"
}

export default function AdminDistributionsScreen() {
Expand Down
Loading