Repository navigation
feat: Introduction of deprecated url dialog - #389
Merged
Merged
Conversation
koebi
requested changes
Sep 24, 2026
Collaborator
There was a problem hiding this comment.
Hey,
currently, we are checking and resetting all URLs.
We only want to do that for api.openrouteservice.org, so we should only check for that.
Also, the first three commits can be dropped, as per #388
However, this code requires a feature from #388, so rather than git rebase -i main, git rebase -i update_default_url can be used :)
Comment on lines
+138
to
+139
| if provider_config.get("base_url") != default_url: | ||
| provider_config["base_url"] = default_url |
Collaborator
There was a problem hiding this comment.
Issue: This resets all base URLs to the new default.
In fact, we only want to reset api.openrouteservice.org.
Comment on lines
+122
to
+125
| return any( | ||
| provider["base_url"] != DEFAULT_SETTINGS["providers"][0]["base_url"] | ||
| for provider in settings["providers"] | ||
| ) |
Collaborator
There was a problem hiding this comment.
Great use of any()!
Issue: We only want to check whether the user is still using api.openrouteservice.org.
TKleinwort
force-pushed
the
dialog_deprecated_url
branch
from
September 25, 2026 09:36
58b9d51 to
0a8db1b
Compare
TKleinwort
force-pushed
the
dialog_deprecated_url
branch
2 times, most recently
from
October 8, 2026 13:34
c7024ed to
879c205
Compare
koebi
force-pushed
the
dialog_deprecated_url
branch
from
October 23, 2026 10:05
879c205 to
c0ed4f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications adds a new GUI class (DeprecatedUrlDialog), which opens a warning window after the start of qgis in the 4.x version if the old api is still in use. User can decide if the url is automaticly updated or not.