Repository navigation
Mail: close the thread sidebar when the open thread is deleted - #3078
Merged
Merged
Conversation
…ount is removed FocusedContentStore cleared these in place, so WorkspaceStore never heard the thread close and kept the thread sidebar open beside an empty reading pane. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3075. When the open thread was deleted for good, or its account was removed,
FocusedContentStorecleared its focus in place without sendingsetFocus.WorkspaceStorenever heard the thread close, so in split mode the thread sidebar and its Show/Hide button stayed beside an empty reading pane.What changes
FocusedContentStorenow closes the thread withActions.setFocus({ item: null }), like every other close. The keyboard cursor is still cleared in place, and an updated thread is still swapped in place.WorkspaceStorecan't listen toFocusedContentStoredirectly:MailspringStorerejects the loop, sinceFocusedContentStorealready listens toWorkspaceStore.Checked
In the dev app, with the deletion and the account removal faked in memory: split mode closes the reading pane, sidebar and button; list mode returns to the list. The new specs fail against master's
FocusedContentStore.🤖 Generated with Claude Code