Skip to content

Mail: close the thread sidebar when the open thread is deleted - #3078

Merged
manilabui merged 1 commit into
masterfrom
manila/deleted-thread
Nov 20, 2026
Merged

manilabui merged 1 commit into
masterfrom
manila/deleted-thread

Conversation

@manilabui

Copy link
Copy Markdown
Contributor

Follow-up to #3075. When the open thread was deleted for good, or its account was removed, FocusedContentStore cleared its focus in place without sending setFocus. WorkspaceStore never heard the thread close, so in split mode the thread sidebar and its Show/Hide button stayed beside an empty reading pane.

What changes

  • In both cases FocusedContentStore now closes the thread with Actions.setFocus({ item: null }), like every other close. The keyboard cursor is still cleared in place, and an updated thread is still swapped in place.
  • List mode: deleting the open thread now goes back to the list, as closing it does, instead of leaving an empty thread page.

WorkspaceStore can't listen to FocusedContentStore directly: MailspringStore rejects the loop, since FocusedContentStore already listens to WorkspaceStore.

Checked

In the dev app, with the deletion and the account removal faked in memory: split mode closes the reading pane, sidebar and button; list mode returns to the list. The new specs fail against master's FocusedContentStore.

🤖 Generated with Claude Code

…ount is removed

FocusedContentStore cleared these in place, so WorkspaceStore never heard the
thread close and kept the thread sidebar open beside an empty reading pane.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@indent

indent Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Issues

No issues found.

CI Checks

All CI checks passed on 5a3dc9d.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No bugs found in the unfocus-on-delete change.
Full results

Indent Review Agent

  • Summary: No bugs found in the unfocus-on-delete change.
  • Last ran on commit: 5a3dc9d6
  • Latest result
    {
      "summary": "No bugs found in the unfocus-on-delete change.",
      "findings": []
    }

@manilabui
manilabui merged commit 20a712c into master Nov 20, 2026
2 checks passed
@manilabui
manilabui deleted the manila/deleted-thread branch November 20, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant