Repository navigation
Conversation
… revived restart=True is the only way out of the timed-out state, but Bash.parameters only declared 'command', so the model could never send it and one slow command disabled the bash tool for the rest of the run. Declare the switch in the schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bash.execute(command, restart=False)implementsrestart=Trueas the only way to replace a session whose_timed_outflag is set, and_BashSession.run()raisesfor every later command once that flag is set. But
Bash.parametersonly declarescommand-restartis missing from the schema, andto_param()is the only interface the model receives:So one command that exceeds the 120 s session timeout disables the bash tool for the rest of the run, and the tool description's own advice ("retry running the command in the background") cannot take effect because
run()raises before anything reaches the shell. AffectsSWEAgentand the bash tool exported over MCP.Fix
Declare the
restartswitch inBash.parametersso the model can actually recover a timed-out session.Tests
tests/tools/test_bash_restart.py(2 tests):restart;