Repository navigation
Conversation
The prompt/exit-status filter dropped every output line that consisted only of digits, not just the single 'echo \True' status line, so commands such as wc -l, grep -c or seq returned an empty result while reporting success. Drop only the final status line before the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DockerSession.execute()filters command output with:The
isdigit()branch was meant to drop the single exit-status line printed byecho $?, but it drops every output line that consists only of digits. The exit status is always the last line before the$prompt, so numeric command output is silently swallowed while the tool reports success:This hits every sandboxed run (
config.sandbox.use_sandbox=true->DockerSandbox.run_command/SandboxFileOperator) whenever a command prints counts, line numbers, hashes-less numeric ids, timestamps orseqoutput.Fix
Track the line count and only drop the final status line that precedes the prompt, instead of dropping any numeric line.
Tests
tests/sandbox/test_terminal_output_parsing.py(3 tests):wc -loutput is preserved;seq 1 3output is preserved;