Skip to content

Lakehouse example: user-supplied bucket and project, no Eventual defaults - #53

Merged
everettVT merged 1 commit into
mainfrom
lakehouse-no-prod-defaults
Oct 16, 2026
Merged

everettVT merged 1 commit into
mainfrom
lakehouse-no-prod-defaults

Conversation

@everettVT

Copy link
Copy Markdown
Collaborator

What changed

  • GCS_BUCKET no longer defaults to our production bucket. BigLake mode now needs both GCP_PROJECT and GCS_BUCKET; setting only one raises an error instead of falling back.
  • Removed our bucket and GCP project names from .env.example, the lakehouse_analytics README and script docstrings; examples use my-project / my-lakehouse.
  • README tells readers to use their own project and bucket. Local SQLite stays the default when nothing is set.

Tested: ruff check and format pass; get_session() in local mode and the one-var error path checked by hand. Smoke tests do not touch this code.

Caveats: git history still contains the old names.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T21:47:01.747098Z 0a88e9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@everettVT
everettVT merged commit b836887 into main Oct 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant