Skip to content

PUMAS Diagnostics - #475

Draft
cacraigucar wants to merge 13 commits into
ESCOMP:mainfrom
nusbaume:pumas_round4
Draft

cacraigucar wants to merge 13 commits into
ESCOMP:mainfrom
nusbaume:pumas_round4

Conversation

@cacraigucar

Copy link
Copy Markdown
Collaborator

Tag name (The PR title should also include the tag name):
Originator(s): cacraigucar assisted by claude-opus:5.5

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:

  • Added: do_cldliq and micro_mg_adjust_cpt

List all files eliminated and why: N/A

List all files added and what they do:
A schemes/sima_diagnostics/micro_pumas_diagnostics.F90
A schemes/sima_diagnostics/micro_pumas_diagnostics.meta
- introduce PUMAS diagnostics

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status main...<your_branch_name>)
M schemes/pumas/micro_pumas_ccpp_dimensions_post.F90
M schemes/pumas/micro_pumas_ccpp_dimensions_post.meta
- Adds sedimentation_velocity_of_liquid_stratus_cloud_droplet and checks for cld and ice consistency

M schemes/pumas/micro_pumas_ccpp_dimensions_pre.F90
M schemes/pumas/micro_pumas_ccpp_dimensions_pre.meta
- add calculation if micro_mg_adjust_cpt is turned on

M schemes/pumas/pumas_pre_main_namelist.xml
- add hooks for do_cldliq and micro_mg_adjust_cpt

M suites/suite_cam5.xml
M suites/suite_cam7.xml
M test/test_suites/suite_pumas.xml
- add micro_pumas_diagnostics calls

List all automated tests that failed, as well as an explanation for why they weren't fixed:

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?

If yes to the above question, describe how this code was validated with the new/modified features:

atmos_phys0_31_000: Move refactored portable science code for Modal Aerosol Model (MAM), aero wetdep, aero drydep to atmos_phys (ESCOMP#433)
atmos_phys0_32_000: converting the CLUBB portable layer (ESCOMP#452)
atmos_phys0_34_000: Implement and CCPPize MCSP; ZM physics_update fix to match CAM (ESCOMP#453)
@cacraigucar
cacraigucar marked this pull request as draft October 29, 2026 21:49
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

This PR: 12 new standard names (1 likely rename) and 1 removed

Updated every push. Comparing head 79807fd with main at merge-base cec8c93.

New standard name Units Introduced in Also seen in Notes
do_heterogeneous_freezing_by_classical_nucleation_theory flag schemes/microp_aero/hetfrz_classnuc_stub.meta:21 schemes/microp_aero/hetfrz_classnuc_stub_namelist.xml:85
schemes/microp_aero/nucleate_ice_ccpp.meta:22
likely rename of do_heterogeneous_ice_nucleation
do_cloud_liquid_processes flag schemes/pumas/micro_pumas_ccpp_dimensions_post.meta:1165 schemes/pumas/pumas_pre_main_namelist.xml:129
microphysics_process_rates none schemes/pumas/micro_pumas_ccpp_dimensions_post.meta:1172 schemes/sima_diagnostics/micro_pumas_diagnostics.meta:434
do_cold_point_tropopause_temperature_adjustment_for_microphysics flag schemes/pumas/micro_pumas_ccpp_dimensions_pre.meta:609 schemes/pumas/pumas_pre_main_namelist.xml:141
schemes/sima_diagnostics/micro_pumas_diagnostics.meta:64
schemes/sima_diagnostics/micro_pumas_diagnostics.meta:143
schemes/sima_diagnostics/micro_pumas_diagnostics.meta:416
filename_of_stochastic_collection_kernel_for_tau none schemes/pumas/pumas_pre_main.meta:40 schemes/pumas/pumas_pre_main_namelist.xml:370
planet_orbital_eccentricity_factor 1 schemes/sima_diagnostics/micro_pumas_diagnostics.meta:392
planet_obliquity rad schemes/sima_diagnostics/micro_pumas_diagnostics.meta:398
mean_longitude_of_perihelion_at_vernal_equinox rad schemes/sima_diagnostics/micro_pumas_diagnostics.meta:404
moving_vernal_equinox_longitude_of_perihelion_plus_pi rad schemes/sima_diagnostics/micro_pumas_diagnostics.meta:410
accumulated_stratiform_precipitation_rate_for_precipitation_efficiency m s-1 schemes/sima_diagnostics/micro_pumas_diagnostics.meta:726
accumulated_cloud_liquid_condensation_rate_for_precipitation_efficiency m s-1 schemes/sima_diagnostics/micro_pumas_diagnostics.meta:732
number_of_timesteps_accumulated_for_precipitation_efficiency count schemes/sima_diagnostics/micro_pumas_diagnostics.meta:738
Removed standard names (1)
Removed standard name Units Was in Notes
do_heterogeneous_ice_nucleation flag schemes/microp_aero/hetfrz_classnuc_stub.meta:21
schemes/microp_aero/hetfrz_classnuc_stub_namelist.xml:85
schemes/microp_aero/nucleate_ice_ccpp.meta:22
likely renamed to do_heterogeneous_freezing_by_classical_nucleation_theory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant