Repository navigation
Conversation
slipher
force-pushed
the
slipher/irt-tests
branch
2 times, most recently
from
October 14, 2026 11:29
d2884be to
908869f
Compare
slipher
marked this pull request as ready for review
October 14, 2026 11:52
Member
Author
|
Somehow this is not working. None of the IRT tests are actually building or running in the CI. |
It was flaky because the IRT thread exit hook really hooks the thread exit syscall rather than pthread_exit. So the hook can surprisingly run after the thread is already joinable.
Also document them a bit in the README. Fixes #64.
slipher
force-pushed
the
slipher/irt-tests
branch
from
October 27, 2026 20:34
908869f to
e568a7d
Compare
Member
Author
|
Should work now (i.e. actually run IRT tests on the CI). I had enabled the Also added another commit to find |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #64