Repository navigation
Enable nuget Trusted Publishing - #206
Merged
Merged
Conversation
This replaces the explicit API key publish method. We must define a secret in the repo NUGET_USER which is the GitHub username of the person who has set up a trusted publishing configuration.
There was a problem hiding this comment.
🔵 Needs a closer look
It changes the production release/publishing path to nuget.org and requires validating external configuration (trusted publishing + secrets) that can’t be verified from the diff alone.
Pull request overview
Updates the release workflow to publish NuGet packages via NuGet.org Trusted Publishing (OIDC) instead of using a long-lived NuGet API key, aligning the repo’s release process with modern, token-based publishing.
Changes:
- Grants
id-token: writepermissions so the workflow can request an OIDC token for NuGet trusted publishing. - Adds a
NuGet/login@v1step to obtain a short-lived NuGet API key for stable releases. - Switches the nuget.org push step to use the temporary API key output from the login step.
File summaries
| File | Description |
|---|---|
| .github/workflows/release.yml | Adds OIDC permission + NuGet/login step and uses its temporary API key to push stable packages to nuget.org. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the explicit API key publish method. We must define a secret in the repo NUGET_USER which is the GitHub username of the person who has set up a trusted publishing configuration.
What type of PR is this? (check all applicable)