Repository navigation
feat(ci): support configurable and RC Docker images in E2E and promotion workflows - #5824
Open
chiajunglien wants to merge 1 commit into
Open
chiajunglien wants to merge 1 commit into
chiajunglien wants to merge 1 commit into
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chiajunglien
force-pushed
the
emma/configurable-e2e-docker-images
branch
from
October 19, 2026 08:35
16aeea4 to
ec0c694
Compare
chiajunglien
force-pushed
the
emma/configurable-e2e-docker-images
branch
3 times, most recently
from
October 20, 2026 03:01
c0baf35 to
68a9cb0
Compare
chiajunglien
force-pushed
the
emma/configurable-e2e-docker-images
branch
from
October 21, 2026 03:56
68a9cb0 to
15964de
Compare
This was referenced Oct 21, 2026
chiajunglien
marked this pull request as ready for review
October 21, 2026 07:35
chiajunglien
requested review from
bvandermoon,
darisoy,
gobbleturk,
khatwanimohit,
parambole,
richjames0,
shralex and
xibinliu
as code owners
October 21, 2026 07:35
chiajunglien
requested review from
huytransformer and
igorts-git
as code owners
October 21, 2026 07:35
Collaborator
Author
|
Also addressed the points we discussed offline:
Other changes that follow from the above:
|
…ion workflows Signed-off-by: EmmaLien <emmalien@google.com>
chiajunglien
force-pushed
the
emma/configurable-e2e-docker-images
branch
from
October 21, 2026 23:31
15964de to
fe2dbb0
Compare
SurbhiJainUSC
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves:
run_e2e_tests.yml,promote_docker_image.yml, andmaxtext_e2e_testsAirflow DAG to accept configurable Docker imagespromote_docker_image.ymlto tag RC imagesCompanion Airflow PR: GoogleCloudPlatform/ml-auto-solutions#1414. Since neither side keeps a fallback, the two PRs should land together.
Changes
.github/workflows/rc_release.yml(b/573710066):mode: release_candidatetorun_e2e_tests.yml, resolvingTODO(b/573710066)..github/workflows/run_e2e_tests.yml(b/573710066):mode:tpu_pre_training:<short_sha>/tpu_post_training:<short_sha>forrelease_candidate, andmaxtext_jax_<mode>:<run_id>/maxtext_post_training_<mode>:<run_id>otherwise.docker_imagesdict withtpu_pre_training/tpu_post_trainingkeys..github/workflows/promote_docker_image.yml(b/573710066, b/574141449):client_payload.docker_image), or the requireddocker_imageinput (full image URI) for manual runs. Removed the job matrix, hardcoded image names,Checkout MaxText, andpromote_from_staging().IMAGE_TAG, so Airflow and manual runs go through the same path.:verified-e2e-${IMAGE_TAG}and remove any stale:failed-e2e-${IMAGE_TAG}. Daily stable images are also promoted to:latest, together with the matching nightly image, if:verified-ci-${IMAGE_TAG}exists (replacinggh run watch). RC images skip:latestsince they already get:latest-rcat build time.:failed-e2e-${IMAGE_TAG}. On an unexpected state, attach:unknown-e2e-${IMAGE_TAG}. The workflow no longer fails in either case.Tests
tpu_pre_training:1ed249candtpu_post_training:1ed249c): both got:verified-e2e-1ed249cand no:latest, includingtpu_post_training, which has:verified-ci-1ed249c. The test tags were removed afterwards.gcloud: pass / fail / unknown states,:latestfor stable images only (with nightly promotion), missing nightly image, and missing image.maxtext_e2e_testsGoogleCloudPlatform/ml-auto-solutions#1414:docker_imagessent to Airflow, and the callbackstate/docker_imageread back.codespell,yamllint, andactionlintpassed.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.