Skip to content

v1.0.6: validate on the export's inputs, results for bugphyzzExports v1.1.0 - #7

Merged
lwaldron merged 2 commits into
mainfrom
export-inputs
Nov 8, 2026
Merged

lwaldron merged 2 commits into
mainfrom
export-inputs

Conversation

@lwaldron

@lwaldron lwaldron commented Nov 8, 2026

Copy link
Copy Markdown
Member
  • export_inputs.R, called by the three prediction scripts after physiologies(), drops the rows the bugphyzzExports export drops: the 2020 Bergey's scrape (bugphyzzExports ADR 0002) and sources/sheet_overrides.tsv (ADR 0005). It reads the rules from a bugphyzzExports clone (BUGPHYZZEXPORTS_DIR, default ~/git/bugphyzzExports).
  • 02_validation_binary.sh looked for biofilm_forming; the prediction step writes biofilm_formation.
  • run_all.sh was only on supermicro; now tracked.
  • Results v1.0.6, run 2026-11-07/08 on the sources of bugphyzzExports 07a5072; README log has the details. Rank all: 11 physiology/value pairs pass the export thresholds (10 in v1.0.5); COGEM 3 crosses 0.7; coding genes, genome size and G+C content improve. host-associated (only TRUE values now) and biofilm formation (too little of the tree) are not validated.

Before running, refresh the cache with bugphyzz::physiologies("all", forceDownload = TRUE); otherwise physiologies() reuses older downloaded sources.

Drafted with Claude Code.

lwaldron and others added 2 commits November 8, 2026 08:23
…k run_all.sh

export_inputs.R drops what bugphyzzExports drops before ASR: the 2020
Bergey's scrape (ADR 0002) and sources/sheet_overrides.tsv (ADR 0005).

Co-authored-by: Claude Code <noreply@anthropic.com>
Co-authored-by: Claude Code <noreply@anthropic.com>
@claude

claude Bot commented Nov 8, 2026

Copy link
Copy Markdown

I found nothing worth raising. This repo is a validation-scripts repo, not an R package: it has no DESCRIPTION, NAMESPACE or man/, so the Bioconductor export-documentation checks don't apply. The new export_inputs is called in all three prediction scripts, and log_print is available in each because logr is loaded. I didn't run the scripts, because they need a bugphyzzExports clone and the full data cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant