Skip to content

ios: wait for the limited attachment grid in its hosted test - #2016

Merged
ex3ndr merged 1 commit into
mainfrom
steve/ios-attach-grid-test-readiness
Nov 9, 2026
Merged

ex3ndr merged 1 commit into
mainfrom
steve/ios-attach-grid-test-readiness

Conversation

@ex3ndr

@ex3ndr ex3ndr commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Test-only fix-forward

Wait for the limited-access attachment grid to be visible and contain its seven items before unwrapping it. This moves the existing 10-second condition wait ahead of the unwrap; it does not increase the budget. All grid-count, limited-access note, Manage control and camera geometry assertions remain.

The shared menu() helper waits for presentation and then pauses for 600 ms, which does not establish that the actual grid is ready on a busy runner. This PR changes only the affected test, not app behavior or other test expectations.

History and causality

Verification

  • Exact test: 20 consecutive passes, no retries, on Kirill Mac's iOS 27 simulator with CI's 2.5 time scale.
  • Evidence: /Users/kirilldubovitskiy/ctb-out/attach-readiness.kXmFLt/repeated.xcresult (20 tests, zero failures).
  • Full HostedAttachMenuTests class: 12/12 passed, same directory's suite.xcresult.
  • Independent exact-commit source review: PASS, no findings.

Intentionally left unmerged for coordinator review. BrowserStates/proxy investigation is separate; no browser code, assertion weakening, Preview upload, or infrastructure change is included.

@ex3ndr

ex3ndr commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Merge note (waiver for hosted3 HostedBrowserTests.testNoConnectionNeverCreatesADirectWebView, run 42549317528 attempt 1):

  • Failed at lines 206/207 (problem nil, error view hidden) after 8.5s; the privacy assertion at line 205 passed. This PR touches only HostedAttachMenuTests.swift.
  • Local Mac simulator, exact test: 10/10 on this head 5d266d683, 10/10 on base 6c8758d62.
  • hosted3 rerun (job 128950950921): success.
  • hosted1/2 reruns still fail on known flakes (HomeScroll 389, InstantSignOut 318, SystemMonitor 334, BrowserStates liveArtifact, AttachGesture 541, ChiefOfStaffAsk 81) plus timing/budget tests not on the known list: ChatNavigation 334 (testHowLongAChatTakesToOpen), NavigationTiming 152, ThumbHash 212, BrowserStates testComputerUnreachableAndItsReturnRetriesByItself line 200. None touch the attach menu.
  • Follow-up, not fixed here: the fixed 100ms sleep before the assertion in testNoConnectionNeverCreatesADirectWebView.

@ex3ndr
ex3ndr merged commit b0c0f8a into main Nov 9, 2026
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant