Repository navigation
ios: wait for the limited attachment grid in its hosted test - #2016
Merged
Merged
Conversation
Contributor
Author
|
Merge note (waiver for hosted3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix-forward
Wait for the limited-access attachment grid to be visible and contain its seven items before unwrapping it. This moves the existing 10-second condition wait ahead of the unwrap; it does not increase the budget. All grid-count, limited-access note, Manage control and camera geometry assertions remain.
The shared
menu()helper waits for presentation and then pauses for 600 ms, which does not establish that the actual grid is ready on a busy runner. This PR changes only the affected test, not app behavior or other test expectations.History and causality
6c8758d62: this test failed at line 254 because the grid lookup was nil (job 128934487181).7b37e8efb: the same test passed, in 0.836 seconds (job 128927343478). No earlier occurrence was found in the retained logs.Verification
/Users/kirilldubovitskiy/ctb-out/attach-readiness.kXmFLt/repeated.xcresult(20 tests, zero failures).HostedAttachMenuTestsclass: 12/12 passed, same directory'ssuite.xcresult.Intentionally left unmerged for coordinator review. BrowserStates/proxy investigation is separate; no browser code, assertion weakening, Preview upload, or infrastructure change is included.