Repository navigation
fix(locale): handle delta of zero in Icelandic locale - #1358
Open
vineethsaivs wants to merge 1 commit into
Open
vineethsaivs wants to merge 1 commit into
vineethsaivs wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2313 -2
Branches 358 357 -1
=========================================
- Hits 2315 2313 -2 ☔ View full report in Codecov by Harness. |
Author
|
Friendly bump: still relevant, and it merges cleanly with the base branch. Happy to adjust anything. |
vineethsaivs
force-pushed
the
fix/icelandic-locale-delta-zero
branch
from
October 23, 2026 06:32
ade9d80 to
0304ecc
Compare
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1011. A zero delta in the Icelandic locale now falls back to the future form instead of raising a ValueError, as the issue proposes. For example,
now.humanize(now, locale="is", granularity="year")returns "eftir 0 ár".TestIcelandicLocale.test_format_timeframeused to expect the ValueError for("years", 0). It now asserts"0 ár".