Repository navigation
[AMORO-4447][CI] Prevent multiple assignees from take comments - #4448
Open
sivakumar-mahalingam wants to merge 1 commit into
Open
sivakumar-mahalingam wants to merge 1 commit into
sivakumar-mahalingam wants to merge 1 commit into
Conversation
Contributor
Author
|
take |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The issue-assignment workflow used the additive
addAssigneesAPI for everytakecomment. As a result, multiple users could be assigned when they commentedtakeon the same issue.The workflow should assign only the first user who claims an unassigned issue. Subsequent
takecomments must not change its assignees.Close #4447.
Brief change log
takecomments when the issue is already assigned.takecomment and assign only its author.CONTRIBUTING.mdto document the first-claim behavior.How was this patch tested?
actionlint .github/workflows/take.yml.git diff --check../mvnw validatesuccessfully for all 33 modules.Documentation